Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBA Migration #3204

Merged
merged 180 commits into from
Jan 21, 2025
Merged

RBA Migration #3204

merged 180 commits into from
Jan 21, 2025

Conversation

ljstella
Copy link
Contributor

Details

Content migration accompanying changes to contentctl: splunk/contentctl#263

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

@josehelps josehelps added the 5.0 label Jan 16, 2025
@josehelps josehelps added this to the 5.0 milestone Jan 16, 2025
@ljstella ljstella marked this pull request as ready for review January 17, 2025 22:23
@patel-bhavin
Copy link
Contributor

@ljstella : Shall we update the github workflows build, inpect and test to install the alpha version of contentctl?

@ljstella
Copy link
Contributor Author

ljstella commented Jan 17, 2025

@ljstella : Shall we update the github workflows build, inpect and test to install the alpha version of contentctl?

Once there is an alpha release of contentctl 5.0.0, these are the spots it needs to change (actually, maybe doesn't need to change with that):

Here:

pip install contentctl>=4.0.0

Here:

pip install contentctl>=4.0.0

Here:

pip install contentctl>=4.0.0

Here:

pip install "contentctl>=4.0.0"

@patel-bhavin
Copy link
Contributor

App inspect changes works locally ! LGTM

@patel-bhavin patel-bhavin merged commit f1ca83e into develop Jan 21, 2025
2 of 4 checks passed
@patel-bhavin patel-bhavin deleted the rba_migration branch January 21, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Detections Lookups Stories WIP DO NOT MERGE Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants